Skip to content

M*a should be constant on wind mass loss #1304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ilyamandel merged 3 commits into from
Dec 15, 2024
Merged

M*a should be constant on wind mass loss #1304

ilyamandel merged 3 commits into from
Dec 15, 2024

Conversation

@ilyamandel
Copy link
Collaborator

@ilyamandel ilyamandel commented Dec 5, 2024

Partial fix

@ilyamandel ilyamandel marked this pull request as draft December 5, 2024 08:23
@github-actions
Copy link

github-actions bot commented Dec 5, 2024

badge

Build Successful! You can find a link to the downloadable artifact below.

Name Link
Commit 3f33a58
Logs https://github.com/TeamCOMPAS/COMPAS/actions/runs/12175865123
Download https://github.com/TeamCOMPAS/COMPAS/suites/$SUITE_ID/artifacts/$ARTIFACT_ID

@ilyamandel ilyamandel mentioned this pull request Dec 5, 2024
Closed
@ilyamandel ilyamandel marked this pull request as ready for review December 12, 2024 14:29
@ilyamandel
Copy link
Collaborator Author

ilyamandel commented Dec 12, 2024

See fix description in #1305 .

@ilyamandel ilyamandel mentioned this pull request Dec 14, 2024
Closed
jeffriley
jeffriley approved these changes Dec 14, 2024
View reviewed changes
Copy link
Collaborator

@jeffriley jeffriley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ilyamandel - all good for me. Will leave for @reinhold-willcox to review or you to merge

@ilyamandel
Copy link
Collaborator Author

ilyamandel commented Dec 15, 2024

Thanks, @jeffriley !
I'll pull this because it fixed a non-trivial bug, but if @reinhold-willcox has comments on this I'll be happy to make further improvements.

@ilyamandel ilyamandel merged commit efe2ccc into dev Dec 15, 2024
3 checks passed
@ilyamandel ilyamandel deleted the WindsFix branch December 15, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeffriley jeffriley jeffriley approved these changes

@reinhold-willcox reinhold-willcox Awaiting requested review from reinhold-willcox

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ilyamandel @jeffriley